[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 7 Jul 2008 22:38:07 +0100 (BST)
From: "Maciej W. Rozycki" <macro@...ux-mips.org>
To: "Rafael J. Wysocki" <rjw@...k.pl>
cc: Ingo Molnar <mingo@...e.hu>, Matthew Garrett <mjg59@...f.ucam.org>,
Len Brown <lenb@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
linux-next@...r.kernel.org, linux-acpi@...r.kernel.org,
linux-kernel@...r.kernel.org, Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH 2/2] acpi: Disable IRQ 0 through I/O APIC for some HP
systems
On Mon, 7 Jul 2008, Rafael J. Wysocki wrote:
> > Ingo, from the sequence above, I gather this code is currently in the
> > tree:
> >
> > - replace_pin_at_irq(0, 0, 0, apic1, pin1);
> > - apic1 = 0;
> > - pin1 = 0;
> >
> > Please revert the change which introduced it. While I recall posting a
> > patch which added code like this, I clearly stated it was solely for
> > diagnostics of Rafael's system and not to apply to any tree.
>
> Shouldn't the setup_timer_IRQ0_pin(apic1, pin1, cfg->vector) be removed as
> well?
Yes. The whole commit should be reverted as mentioned in the other
e-mail (it didn't even bear my sign-off mark). This would include the
line you are referring to as well. I have submitted a patch to add a
64-bit variation of replace_pin_at_irq() separately.
Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists