linux-kernel - Re: [PATCH] drm_memory.h: remove double inclusion of linux/vmalloc.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4423d670807080956m4aa548b7vf5557892aae81432@mail.gmail.com>
Date:	Tue, 8 Jul 2008 20:56:00 +0400
From:	"Alexander Beregalov" <a.beregalov@...il.com>
To:	"Ian Romanick" <ianr@...com>
Cc:	"Mark Asselstine" <asselsm@...il.com>, airlied@...ux.ie,
	dri-devel@...ts.sourceforge.net, kernel-janitors@...r.kernel.org,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm_memory.h: remove double inclusion of linux/vmalloc.h

2008/7/8 Ian Romanick <ianr@...com>:
> On Tue, Jul 08, 2008 at 08:29:57AM -0400, Mark Asselstine wrote:
>> On Sun, Jul 6, 2008 at 7:31 AM, Alexander Beregalov
>> <a.beregalov@...il.com> wrote:
>> > From: Alexander Beregalov <a.beregalov@...il.com>
>> >
>> >  #if __OS_HAS_AGP
>> >
>> > -#include <linux/vmalloc.h>
>> > -
>>
>> Why remove this one and not the one at the top of the file? As well
>
> I would assume this one is removed because it is inside additional
> ifdefs.
Yes, it does not change functionality of the code.
>
>> this file has #include of drmP.h, yet drmP.h is the only file I can
>> find that includes drm_memory.h. Based on this I would think there is
>> some additional cleanup that can go on here.
How it can be cleaned up? Do you mean to move `define PAGE_AGP` to drmP.h?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/