linux-kernel - Re: [PATCHv2 6/7] x86: traps_xx: modify default_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 9 Jul 2008 08:19:22 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	Alexander van Heukelum <heukelum@...lshack.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv2 6/7] x86: traps_xx: modify default_do_nmi

* Cyrill Gorcunov <gorcunov@...il.com> wrote:

> [Alexander van Heukelum - Wed, Jul 02, 2008 at 06:39:01PM +0200]
> |  - local caching of smp_processor_id() in default_do_nmi()
> |  - v2: do not split default_do_nmi over two lines
> | 
> | Signed-off-by: Alexander van Heukelum <heukelum@...tmail.fm>
> | 
> | ---
> | 
> | On Wed, Jul 02, 2008 at 08:12:20PM +0400, Cyrill Gorcunov wrote:
> | > | -static notrace __kprobes void default_do_nmi(struct pt_regs *regs)
> | > | +static notrace __kprobes void
> | > | +default_do_nmi(struct pt_regs *regs)
> | > | [ ... ]
> | > | -asmlinkage notrace  __kprobes void default_do_nmi(struct pt_regs *regs)
> | > | +asmlinkage notrace __kprobes void
> | > | +default_do_nmi(struct pt_regs *regs)
> | > 
> | > Hi Alexander, good done, thanks! But why did you split default_do_nmi
> | > definition by two lines? I think it would be better to keep them as it
> | > was before, ie by a single line
> | > 
> | > 	static notrace __kprobes void default_do_nmi(struct pt_regs *regs)
> | 
> | Thanks! Here is the replacement patch with default_do_nmi left on
> | a single line. Patch 7 applies with 1 line fuzz.
> | 
> | Greetings,
> |     Alexander
> | 
> 
> Thanks, Alexander, this looks good to me. Feel free to add my 
> Signed-off if you need it.

Thanks Alexander, i've picked them up into tip/x86/core:

 Alexander van Heukelum (7):
      x86: initial changes to unify traps_32.c and traps_64.c
      x86: traps_xx: shuffle headers and globals
      x86: traps_xx: modify __die
      x86: traps_xx: modify do_trap
      x86: traps_xx: restructure do_general_protection()
      x86: traps_xx: modify default_do_nmi
      x86: traps_xx: various small changes

i've added Cyrill's Acked-by lines as well. (We use Signed-off is when 
routing patches)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/