linux-kernel - Re: [PATCHv2 6/7] x86: traps_xx: modify default_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080702171637.GB7003@cvg>
Date:	Wed, 2 Jul 2008 21:16:38 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Alexander van Heukelum <heukelum@...lshack.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv2 6/7] x86: traps_xx: modify default_do_nmi

[Alexander van Heukelum - Wed, Jul 02, 2008 at 06:39:01PM +0200]
|  - local caching of smp_processor_id() in default_do_nmi()
|  - v2: do not split default_do_nmi over two lines
| 
| Signed-off-by: Alexander van Heukelum <heukelum@...tmail.fm>
| 
| ---
| 
| On Wed, Jul 02, 2008 at 08:12:20PM +0400, Cyrill Gorcunov wrote:
| > | -static notrace __kprobes void default_do_nmi(struct pt_regs *regs)
| > | +static notrace __kprobes void
| > | +default_do_nmi(struct pt_regs *regs)
| > | [ ... ]
| > | -asmlinkage notrace  __kprobes void default_do_nmi(struct pt_regs *regs)
| > | +asmlinkage notrace __kprobes void
| > | +default_do_nmi(struct pt_regs *regs)
| > 
| > Hi Alexander, good done, thanks! But why did you split default_do_nmi
| > definition by two lines? I think it would be better to keep them as it
| > was before, ie by a single line
| > 
| > 	static notrace __kprobes void default_do_nmi(struct pt_regs *regs)
| 
| Thanks! Here is the replacement patch with default_do_nmi left on
| a single line. Patch 7 applies with 1 line fuzz.
| 
| Greetings,
|     Alexander
| 

Thanks, Alexander, this looks good to me. Feel free to add my
Signed-off if you need it.

		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/