linux-kernel - Re: [PATCH] reiserfs: discard prealloc in reiserfs_delete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080711121850.dfd60681.akpm@linux-foundation.org>
Date:	Fri, 11 Jul 2008 12:18:50 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jeff Mahoney <jeffm@...e.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	ReiserFS Mailing List <reiserfs-devel@...r.kernel.org>
Subject: Re: [PATCH] reiserfs: discard prealloc in reiserfs_delete_inode

On Tue, 08 Jul 2008 14:37:06 -0400 Jeff Mahoney <jeffm@...e.com> wrote:

>  With the removal of struct file from the xattr code, reiserfs_file_release()
>  isn't used anymore, so the prealloc isn't discarded. This causes hangs
>  later down the line.
> 
>  This patch adds it to reiserfs_delete_inode. In most cases it will be
>  a no-op due to it already having been called, but will avoid hangs with xattrs.
> 
> Signed-off-by: Jeff Mahoney <jeffm@...e.com>
> ---
>  fs/reiserfs/inode.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- a/fs/reiserfs/inode.c
> +++ b/fs/reiserfs/inode.c
> @@ -45,6 +45,8 @@ void reiserfs_delete_inode(struct inode
>  			goto out;
>  		reiserfs_update_inode_transaction(inode);
>  
> +		reiserfs_discard_prealloc(&th, inode);
> +
>  		err = reiserfs_delete_object(&th, inode);
>  
>  		/* Do quota update inside a transaction for journaled quotas. We must do that

Can you please remind us when "the removal of struct file from the xattr
code" happened?

Because hangs aren't good, and 2.6.25 might want this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/