lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 11 Jul 2008 12:18:33 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: Daniel Guilak <guilak@...ux.vnet.ibm.com> Cc: linux-kernel@...r.kernel.org, trivial@...nel.org, torvalds@...ux-foundation.org, daniel@...ielguilak.com Subject: Re: [PATCH] init/version.c: Silenced sparse warning by declaring the version string. On Tue, 08 Jul 2008 14:21:09 -0700 Daniel Guilak <guilak@...ux.vnet.ibm.com> wrote: > Signed-off-by: Daniel Guilak <daniel@...ielguilak.com> Please always quote the warning or error message in the changelog when fixing it. Although it's pretty obvious in this case. > init/version.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/init/version.c b/init/version.c > index 9d17d70..041fd82 100644 > --- a/init/version.c > +++ b/init/version.c > @@ -16,6 +16,7 @@ > #define version(a) Version_ ## a > #define version_string(a) version(a) > > +extern int version_string(LINUX_VERSION_CODE); > int version_string(LINUX_VERSION_CODE); > > struct uts_namespace init_uts_ns = { hrm, what does this thing do? Seems to define int Version_132634; Then sticks that in the symbol table (and wastes a bit of bss). Does anything use it? Could it be made static? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists