linux-kernel - Re: [PATCH 1/2] I/OAT: Add watchdog/reset functionality to ioatdma driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9c3a7c20807111307q1b7c4ed0wb2864e2dae6abe90@mail.gmail.com>
Date:	Fri, 11 Jul 2008 13:07:24 -0700
From:	"Dan Williams" <dan.j.williams@...el.com>
To:	"Maciej Sosnowski" <maciej.sosnowski@...el.com>
Cc:	shannon.nelson@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] I/OAT: Add watchdog/reset functionality to ioatdma driver

On Fri, Jul 11, 2008 at 4:36 AM, Maciej Sosnowski
<maciej.sosnowski@...el.com> wrote:
> Due to occasional DMA channel hangs observed for I/OAT versions 1.2 and 2.0
> a watchdog has been introduced to check every 2 seconds
> if all channels progress normally.
> If stuck channel is detected, driver resets it.
> The reset is done in two parts. The second part is scheduled
> by the first one to reinitialize the channel after the restart.
>

checkpatch had some valid suggestions, please give it a run.

A general comment about this change it seems to add a bit of
complexity.  The driver now has two workqueue routines and a tasklet.
Might some of these be combined?  In other words, do we need a free
running watchdog when no descriptors are in flight?  It seems that
using a timer to kick the cleanup tasklet could be used in place of
the ioat_dma_chan_watchdog workqueue.

> Sleep time in self_test has been increased to 10ms
> since in some cases 1ms appeared not to be enough.

This should be broken out into a separate patch.  Perhaps with an
explanation of why it needs extra time for this particular
transaction.

Regards,
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/