linux-kernel - Re: [patch 00/26] x64, x2apic/intr-remap: Interrupt-remapping and x2apic support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080711200957.GA8173@elte.hu>
Date:	Fri, 11 Jul 2008 22:09:57 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Suresh Siddha <suresh.b.siddha@...el.com>
Cc:	"hpa@...or.com" <hpa@...or.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"arjan@...ux.intel.com" <arjan@...ux.intel.com>,
	"andi@...stfloor.org" <andi@...stfloor.org>,
	"ebiederm@...ssion.com" <ebiederm@...ssion.com>,
	"jbarnes@...tuousgeek.org" <jbarnes@...tuousgeek.org>,
	"steiner@....com" <steiner@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	jeremy@...p.org
Subject: Re: [patch 00/26] x64, x2apic/intr-remap: Interrupt-remapping and
	x2apic support


* Ingo Molnar <mingo@...e.hu> wrote:

> > >   http://redhat.com/~mingo/misc/config-Thu_Jul_10_21_43_28_CEST_2008.bad
> > 
> > Ingo, that was my stupid typo. Please apply this patch. BTW, we need 
> > some more xen64 paravirt fixes in this area. I will look at it as 
> > soon as possible.
> 
> applied to tip/x86/x2apic - thanks Suresh.

another problem is the redefinition of apic_read(), causing:

 arch/x86/xen/enlighten.c: In function ‘xen_patch':
 arch/x86/xen/enlighten.c:1084: warning: label ‘patch_site' defined but not used
 arch/x86/xen/enlighten.c: At top level:
 arch/x86/xen/enlighten.c:1272: error: expected identifier before ‘(' token
 arch/x86/xen/enlighten.c:1273: error: expected ‘}' before ‘.' token

with this config:

  http://redhat.com/~mingo/misc/config-Fri_Jul_11_21_51_18_CEST_2008.bad

the continued spaghetti in all the APIC variants is quite ugly. This 
should all be handled via a single apic_ops template that should cover 
the paravirt and native variants as well.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/