linux-kernel - Re: [PATCH 2.6.25.10 1/2] libata: fix locking for kmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080713012630.d5e522f7.akpm@linux-foundation.org>
Date:	Sun, 13 Jul 2008 01:26:30 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Jakub W. Jozwicki" <jozwicki@...er.pl>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.25.10 1/2] libata: fix locking for kmap_atomic

On Sun, 13 Jul 2008 01:27:36 +0200 "Jakub W. Jozwicki" <jozwicki@...er.pl> wrote:

> Change locking surrounding kmap_atomic from local_irqsave to 
> local_irqsave_nort. This fixes issues with PREEMPT_RT.
>  

I assume this is a -rt kernel patch.

> 
> --- linux-2.6.25.10/drivers/ata/libata-core.c	2008-07-03 05:46:47.000000000 
> +0200
> +++ linux-2.6.25.10-rt7/drivers/ata/libata-core.c	2008-07-12 
> 23:59:33.132140258 +0200
> @@ -5157,14 +5157,14 @@
>  		unsigned long flags;
>  
>  		/* FIXME: use a bounce buffer */
> -		local_irq_save(flags);
> +		local_irq_save_nort(flags);

eww.  If we're going to have to do stuff like this in mainline then
there might be a revolt.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/