[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1216099851.4265.156.camel@moss.renham>
Date: Tue, 15 Jul 2008 15:30:51 +1000
From: Ben Nizette <bn@...sdigital.com>
To: Michael Buesch <mb@...sch.de>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Stephen Rothwell <sfr@...b.auug.org.au>,
linux-kernel <linux-kernel@...r.kernel.org>,
David Brownell <david-b@...bell.net>,
Piot Skamruk <piotr.skamruk@...il.com>,
openwrt-devel@...ts.openwrt.org
Subject: Re: [PATCH] Add SPI over GPIO driver
On Mon, 2008-07-14 at 21:09 +0200, Michael Buesch wrote:
> This adds a driver that lets you drive an SPI bus over
> generic GPIO pins.
Right, this is where spi-gpio is, please disregard my question in the
mmc-spi-gpio thing thread, it was domestic blindness after all :-)
Looks good overall. I'm not sure that it need pretend to be
hotpluggable though (i.e. the board info can be hardwired so there's no
need for the board setup callback). I guess this is to integrate with
your "dynamically create an mmc over spi over gpio" thinggy in the other
thread. As I said there, I'd prefer that this platform device is
treated like other platform devices and any dynamicness be introduced at
in a more generic way.
What problem are you solving (or whole in board support are you
plugging) in this dynamic plugging of MMCs?
Thanks,
--Ben.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists