linux-kernel - Re: [PATCH] Add SPI over GPIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080714134345.a2287c6c.akpm@linux-foundation.org>
Date:	Mon, 14 Jul 2008 13:43:45 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Michael Buesch <mb@...sch.de>
Cc:	sfr@...b.auug.org.au, linux-kernel@...r.kernel.org,
	david-b@...bell.net, piotr.skamruk@...il.com,
	openwrt-devel@...ts.openwrt.org
Subject: Re: [PATCH] Add SPI over GPIO driver

On Mon, 14 Jul 2008 21:09:12 +0200
Michael Buesch <mb@...sch.de> wrote:

> +static inline void do_spidelay(struct spi_device *dev, unsigned nsecs)
> +{
> +	struct spi_gpio *sp = spidev_to_sg(dev);
> +
> +	if (!sp->info->no_spi_delay)
> +		ndelay(nsecs);
> +}
> +
> +#define spidelay(nsecs) do {					\
> +	/* Steal the spi_device pointer from our caller.	\
> +	 * The bitbang-API should probably get fixed here... */	\
> +	do_spidelay(spi, nsecs);				\
> +  } while (0)

A macro which requires that its caller have a particular local variable
is a bit nasty.  Could we plan to add the spi_device* to spidelay()
please? 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/