lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 14 Jul 2008 17:50:24 -0700 From: David Woodhouse <dwmw2@...radead.org> To: Yinghai Lu <yhlu.kernel@...il.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, torvalds@...ux-foundation.org, alan@...rguk.ukuu.org.uk, linux-kernel@...r.kernel.org Subject: Re: [GIT *] Allow request_firmware() to be satisfied from in-kernel, use it in more drivers. On Mon, 2008-07-14 at 17:31 -0700, Yinghai Lu wrote: > make[1]: *** No rule to make target > `include/config/builtin/firmware/dir.h', needed by > `firmware/ql2100_fw.bin.gen.S'. Stop. > make: *** [firmware] Error 2 Oh, pants. Sorry, I renamed the CONFIG_BUILTIN_FIRMWARE option to CONFIG_EXTRA_FIRMWARE some time back, but all my own test builds had the include/config/builtin/firmware/dir.h file still lying around so I didn't notice that I'd forgotten to change that manual dependency. And evidently nobody using linux-next actually tried to include arbitrary _other_ firmware into their tree. This patch should fix it... (Why _do_ we have stray files left in include/config/ when config options go away, btw? Shouldn't they get deleted?) ---- Subject: firmware: Correct dependency on CONFIG_EXTRA_FIRMWARE_DIR When CONFIG_EXTRA_FIRMWARE_DIR gets changed, the filename in the .S file (which uses .incbin to include the binary) needs to change. When we renamed the BUILTIN_FIRMWARE_DIR option to EXTRA_FIRMWARE_DIR, we forgot to update the manual dependency in firmware/Makefile, so it was depending on a non-existent file in include/config/ Signed-off-by: David Woodhouse <David.Woodhouse@...el.com> diff --git a/firmware/Makefile b/firmware/Makefile index 5a1e61c..ec4f0cc 100644 --- a/firmware/Makefile +++ b/firmware/Makefile @@ -146,7 +146,7 @@ $(patsubst %,$(obj)/%.gen.S, $(fw-shipped-y)): %: $(wordsize_deps) \ | $(objtree)/$$(dir %) $(call cmd,fwbin,$(patsubst %.gen.S,%,$@)) $(patsubst %,$(obj)/%.gen.S, $(fw-external-y)): %: $(wordsize_deps) \ - include/config/builtin/firmware/dir.h | $(objtree)/$$(dir %) + include/config/extra/firmware/dir.h | $(objtree)/$$(dir %) $(call cmd,fwbin,$(fwabs)/$(patsubst $(obj)/%.gen.S,%,$@)) # The .o files depend on the binaries directly; the .S files don't. -- dwmw2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists