linux-kernel - Re: [PATCH] x86: Introducing asm-x86/syscalls.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1216133883.27455.252.camel@shinybook.infradead.org>
Date:	Tue, 15 Jul 2008 07:58:03 -0700
From:	David Woodhouse <dwmw2@...radead.org>
To:	Jaswinder Singh <jaswinder@...radead.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	kernelnewbies <kernelnewbies@...linux.org>,
	kernel-janitors <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] x86: Introducing asm-x86/syscalls.h

On Tue, 2008-07-15 at 18:36 +0530, Jaswinder Singh wrote:
> Updated Patch:
> 
> declaring arch-dependent syscalls for x86 under one hood

Thanks Jaswinder, this looks quite sensible in general and should go
some way towards making sparse shut up about undeclared functions. You
should Cc Ingo though.

I don't like this bit though:

> --- a/include/linux/syscalls.h
> +++ b/include/linux/syscalls.h
> @@ -65,6 +65,10 @@ struct getcpu_cache;
>  #include <linux/quota.h>
>  #include <linux/key.h>
>  
> +#ifdef CONFIG_X86
> +#include <asm/syscalls.h>
> +#endif
> +
>  asmlinkage long sys_time(time_t __user *tloc);
>  asmlinkage long sys_stime(time_t __user *tptr);
>  asmlinkage long sys_gettimeofday(struct timeval __user *tv,

We're going to want to do this for all architectures, aren't we? Perhaps
it's better to provide <asm/syscalls.h> for all architectures from the
beginning, and not bother with the ifdef? Or if you must have an ifdef,
perhaps make it on something like ARCH_HAS_ASM_SYSCALLS_H rather than
having to change it every time an architecture adds its own
<asm/syscalls.h> file?

-- 
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/