linux-kernel - Re: [PATCH] prng; bring prng into better alignment with specification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080717074856.GB23621@gondor.apana.org.au>
Date:	Thu, 17 Jul 2008 15:48:56 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Neil Horman <nhorman@...driver.com>
Cc:	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	davem@...emloft.net
Subject: Re: [PATCH] prng; bring prng into better alignment with specification

On Wed, Jul 16, 2008 at 04:32:00PM -0400, Neil Horman wrote:
>  Bring prng into better alignment with specificaion:
>     
>  - Convert to using Generic AES 128 bit cipher
>  - Convert DT to be a non-shifted counter, increasing counter period
>     
>  Signed-off-by: Neil Horman <nhorman@...driver.com>

Applied to cryptodev-2.6.
>
> @@ -325,17 +306,13 @@ int reset_prng_context(struct prng_context *ctx,
>  		       unsigned char *V, unsigned char *DT)
>  	int ret;
> -	int iv_len;
>  	int rc = -EFAULT;
>  	unsigned char *prng_key;
> -	unsigned char *prng_iv;
>  	spin_lock(&ctx->prng_lock);
>  	ctx->flags |= PRNG_NEED_RESET;
>  
>  	prng_key = (key != NULL) ? key : (unsigned char *)DEFAULT_PRNG_KEY;
>  
> -	prng_iv = iv ? iv : (unsigned char *)DEFAULT_PRNG_IV;

We can now kill the iv parameter too.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/