linux-kernel - Re: [PATCH] prng; bring prng into better alignment with specification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 17 Jul 2008 07:04:05 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	davem@...emloft.net
Subject: Re: [PATCH] prng; bring prng into better alignment with specification

On Thu, Jul 17, 2008 at 03:48:56PM +0800, Herbert Xu wrote:
> On Wed, Jul 16, 2008 at 04:32:00PM -0400, Neil Horman wrote:
> >  Bring prng into better alignment with specificaion:
> >     
> >  - Convert to using Generic AES 128 bit cipher
> >  - Convert DT to be a non-shifted counter, increasing counter period
> >     
> >  Signed-off-by: Neil Horman <nhorman@...driver.com>
> 
> Applied to cryptodev-2.6.
> >
> > @@ -325,17 +306,13 @@ int reset_prng_context(struct prng_context *ctx,
> >  		       unsigned char *V, unsigned char *DT)
> >  	int ret;
> > -	int iv_len;
> >  	int rc = -EFAULT;
> >  	unsigned char *prng_key;
> > -	unsigned char *prng_iv;
> >  	spin_lock(&ctx->prng_lock);
> >  	ctx->flags |= PRNG_NEED_RESET;
> >  
> >  	prng_key = (key != NULL) ? key : (unsigned char *)DEFAULT_PRNG_KEY;
> >  
> > -	prng_iv = iv ? iv : (unsigned char *)DEFAULT_PRNG_IV;
> 
> We can now kill the iv parameter too.
> 
Yeah, I was trying to decide if I should remove that or not, in the event we
wanted to support alternate [blk]ciphers in the future for the cprng.  As I
think about it, I don't think its a big deal to nix.  I'll get rid of it
shortly.

Thanks
Neil

> Thanks,
> -- 
> Visit Openswan at http://www.openswan.org/
> Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

-- 
/***************************************************
 *Neil Horman
 *nhorman@...driver.com
 *gpg keyid: 1024D / 0x92A74FA1
 *http://pgp.mit.edu
 ***************************************************/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/