linux-kernel - Re: [PATCH 2/2] signals: replace p->pid == 1 check with a check for task_child

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m1fxq8tkcl.fsf@frodo.ebiederm.org>
Date:	Thu, 17 Jul 2008 11:51:38 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	"Daniel Hokka Zakrisson" <daniel@...ac.com>
Cc:	linux-kernel@...r.kernel.org,
	containers@...ts.linux-foundation.org, oleg@...sign.ru,
	xemul@...nvz.org, akpm@...ux-foundation.org
Subject: Re: [PATCH 2/2] signals: replace p->pid == 1 check with a check  for task_child_reaper

"Daniel Hokka Zakrisson" <daniel@...ac.com> writes:

> Eric W. Biederman wrote:
>> Daniel Hokka Zakrisson <daniel@...ac.com> writes:
>>
>>> p->pid == 1 is insufficient when there are multiple pid namespaces.
>>> Instead, check whether the task is in the current task's
>>> child reaper's thread group.
>>
>> We should just drop the check for init as it is redundant.

Sorry that was a half truth.  Outside of the context of pid namespaces it is true.

In the context of pid namespaces it is false because we haven't merged the patches
to drop signals from inside the pid namespace on the way to init.

So it is a check that _should_ be redundant.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/