linux-kernel - Re: [PATCH v3] leds: implement OpenFirmare GPIO LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1216330141.7559.950.camel@localhost.localdomain>
Date:	Thu, 17 Jul 2008 16:29:01 -0500
From:	Nate Case <ncase@...-inc.com>
To:	Anton Vorontsov <avorontsov@...mvista.com>
Cc:	Richard Purdie <rpurdie@...ys.net>, linuxppc-dev@...abs.org,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] leds: implement OpenFirmare GPIO LED driver

On Tue, 2008-07-15 at 19:19 +0400, Anton Vorontsov wrote:
> +       led->cdev.name = of_get_property(np, "label", NULL);
> +       if (!led->cdev.name)
> +               led->cdev.name = dev_name(&ofdev->dev);

How about also supporting a "trigger" property which would set
cdev.default_trigger in the same manner?  It would be useful for boards
to be able to specify this in the device tree (e.g., if a certain LED is
meant to be used as a "heartbeat").

-- 
Nate Case <ncase@...-inc.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/