linux-kernel - Re: [PATCH 04/05] i2c-sh_mobile: IORESOURCE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080718080457.GM24620@fluff.org.uk>
Date:	Fri, 18 Jul 2008 09:04:57 +0100
From:	Ben Dooks <ben-linux@...ff.org>
To:	Magnus Damm <magnus.damm@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-sh@...r.kernel.org,
	gregkh@...e.de, lethal@...ux-sh.org, i2c@...sensors.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH 04/05] i2c-sh_mobile: IORESOURCE_CLK support

On Fri, Jul 18, 2008 at 04:40:36PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@...l.co.jp>
> 
> This patch makes the i2c-sh_mobile driver get the clock name from the
> struct resource with type IORESOURCE_CLK provided by the platform data.
> 
> Signed-off-by: Magnus Damm <damm@...l.co.jp>
> ---
> 
>  drivers/i2c/busses/i2c-sh_mobile.c |    8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> --- 0001/drivers/i2c/busses/i2c-sh_mobile.c
> +++ work/drivers/i2c/busses/i2c-sh_mobile.c	2008-07-18 14:56:40.000000000 +0900
> @@ -390,13 +390,19 @@ static int sh_mobile_i2c_probe(struct pl
>  	int size;
>  	int ret;
>  
> +	res = platform_get_resource(dev, IORESOURCE_CLK, 0);
> +	if (res == NULL || res->name == NULL) {
> +		dev_err(&dev->dev, "cannot find CLK resource\n");
> +		return -ENOENT;
> +	}
> +
>  	pd = kzalloc(sizeof(struct sh_mobile_i2c_data), GFP_KERNEL);
>  	if (pd == NULL) {
>  		dev_err(&dev->dev, "cannot allocate private data\n");
>  		return -ENOMEM;
>  	}
>  
> -	pd->clk = clk_get(&dev->dev, "peripheral_clk");

I think that is working correctly and there isn't really any
need to change this. The clk_get is supplied the device that
it needs the clock for, and the name of the clock needed.

> +	pd->clk = clk_get(&dev->dev, res->name);
>  	if (IS_ERR(pd->clk)) {
>  		dev_err(&dev->dev, "cannot get peripheral clock\n");
>  		ret = PTR_ERR(pd->clk);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Ben (ben@...ff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/