lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 Jul 2008 13:57:00 +0200 From: Petr Tesarik <ptesarik@...e.cz> To: Christoph Hellwig <hch@...radead.org> Cc: Alexey Dobriyan <adobriyan@...il.com>, Roland McGrath <roland@...hat.com>, Andrew Morton <akpm@...ux-foundation.org>, Linus Torvalds <torvalds@...ux-foundation.org>, Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 01/23] tracehook: add linux/tracehook.h On Thu, 2008-07-17 at 09:34 -0400, Christoph Hellwig wrote: > On Thu, Jul 17, 2008 at 12:48:18PM +0400, Alexey Dobriyan wrote: > > > The new linux/ptrace.h inlines are used by the following patches in the > > > new tracehook_*() inlines. Using these helpers for the ptrace event > > > stops makes it simple to change or disable the old ptrace implementation > > > of these stops conditionally later. > > > > Call them "utrace_*" from the start? > > Yes, please. > > > Pointless 1:1 wrapper unless you're going to #ifdef ->ptrace later. > > Even then I don't think it's a good idea. This one should only be > touched in very very few places So, do you suggest putting those #ifdef's in the middle of the function which uses it? Anyway, this patch should probably be posted later, i.e. when the other implementation is actually introduced. My $0.02. Petr -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists