linux-kernel - The request_firmware() changes causing problems with make-kpkg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 18 Jul 2008 07:58:33 -0400
From:	Theodore Tso <tytso@....edu>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	linux-kernel@...r.kernel.org, sam@...nborg.org
Subject: The request_firmware() changes causing problems with make-kpkg

Using 2.6.26-git4 and -git6, and with CONFIG_FIRMWARE_IN_KERNEL=y,
make modules_install is calling firmware_install, which is dropping
files in /lib/firmware --- which make-kpkg is happily picking up and
including in the debian kernel package.  Which was fine --- until I
tried to build and install kernel package for -git6, at which point I
got an error at install time because the second package was tying to
overwrite files installed by the first linux-image file.  Doh!

Given that Ubuntu's firmware loader already tries to find firmware at
/lib/firmware/<kpkg> and only if that fails, to load it from
/lib/firmware, it seems like the obvious thing to do is to add a
quickie CONFIG option which changes the default setting of
INSTALL_FW_PATH in the top-level makefile from /lib/firwmare to
/lib/firmware/<kver>.

Maybe the userspace for other distributions won't support this, but
they can simply not use this CONFIG option for now; but it will solve
the problem for all Ubuntu, and possibly Debian, users who want to
build their own kernel using make-kpkg.  If I cons a patch like this,
is there likely going to be any objections with it getting merged?

Regards,

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/