linux-kernel - Re: [PATCH] x86: APIC: Remove apic_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440807181551l7e6e143dy7cea8ab59f1830ed@mail.gmail.com>
Date:	Fri, 18 Jul 2008 15:51:07 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Suresh Siddha" <suresh.b.siddha@...el.com>
Cc:	"Zachary Amsden" <zach@...are.com>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	"Ingo Molnar" <mingo@...e.hu>, "x86@...nel.org" <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Jeremy Fitzhardinge" <jeremy@...p.org>
Subject: Re: [PATCH] x86: APIC: Remove apic_write_around(); use alternatives

On Fri, Jul 18, 2008 at 3:49 PM, Suresh Siddha
<suresh.b.siddha@...el.com> wrote:
> On Fri, Jul 18, 2008 at 03:42:17PM -0700, Zachary Amsden wrote:
>> On Fri, 2008-07-18 at 15:02 -0700, Maciej W. Rozycki wrote:
>> > On Fri, 18 Jul 2008, Yinghai Lu wrote:
>> >
>> > >   CC      arch/x86/kernel/apic_64.o
>> > > arch/x86/kernel/apic_64.c:170: error: unknown field 'write_atomic'
>> > > specified in initializer
>> > > arch/x86/kernel/apic_64.c:170: error: 'native_apic_mem_write_atomic'
>> > > undeclared here (not in a function)
>> > > arch/x86/kernel/apic_64.c:209: error: unknown field 'write_atomic'
>> > > specified in initializer
>> > > arch/x86/kernel/apic_64.c:209: warning: initialization from
>> > > incompatible pointer type
>> > > make[1]: *** [arch/x86/kernel/apic_64.o] Error 1
>> > > make: *** [arch/x86/kernel] Error 2
>> >
>> >  Just remove the offending initialisers.  They are not needed anymore as
>> > the .write method is now used universally including places where
>> > .write_atomic was.  I just could not stand watching the thing
>> > proliferate...
>>
>> Thank you for cleaning this up Yinghai, but this really begs the
>> question - is having write_atomic REALLY worthwhile?
>
> And this thread is about,  Maciej's cleanup patch which removed
> write_atomic completely :)
>
> Thanks to Maciej who posted this fix. It was on my todo list for
> sometime now!

do we rebase tip/x86/x2apic or rework this patch?

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/