linux-kernel - Re: [PATCH 18/79] device create: macintosh: convert device_create to device_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1216764016.11027.209.camel@pasglop>
Date:	Wed, 23 Jul 2008 08:00:16 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Greg Kroah-Hartman <gregkh@...e.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 18/79] device create: macintosh: convert device_create
	to device_create_drvdata

On Mon, 2008-07-21 at 22:18 -0700, Greg Kroah-Hartman wrote:
> device_create() is race-prone, so use the race-free
> device_create_drvdata() instead as device_create() is going away.

Acked-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>

> ---
>  drivers/macintosh/adb.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/macintosh/adb.c b/drivers/macintosh/adb.c
> index e5d4468..cae5248 100644
> --- a/drivers/macintosh/adb.c
> +++ b/drivers/macintosh/adb.c
> @@ -862,7 +862,8 @@ adbdev_init(void)
>  	adb_dev_class = class_create(THIS_MODULE, "adb");
>  	if (IS_ERR(adb_dev_class))
>  		return;
> -	device_create(adb_dev_class, NULL, MKDEV(ADB_MAJOR, 0), "adb");
> +	device_create_drvdata(adb_dev_class, NULL, MKDEV(ADB_MAJOR, 0), NULL,
> +			      "adb");
>  
>  	platform_device_register(&adb_pfdev);
>  	platform_driver_probe(&adb_pfdrv, adb_dummy_probe);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/