| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <200807230125.02532.ioe-lkml@rameria.de> Date: Wed, 23 Jul 2008 01:25:01 +0200 From: Ingo Oeser <ioe-lkml@...eria.de> To: Greg KH <gregkh@...e.de> Cc: linux-kernel@...r.kernel.org, Kay Sievers <kay.sievers@...y.org> Subject: [PATCH] kobject: Replace ALL occurrences of '/' with '!' instead of only the first one. From: Ingo Oeser <ioe-lkml@...eria.de> A recent patch from Kay Sievers <kay.sievers@...y.org> replaced the first occurrence of '/' with '!' as needed for block devices. Now do some cheap defensive coding and replace all of them to avoid future issues in this area. Signed-off-by: Ingo Oeser <ioe-lkml@...eria.de> --- To answer your questions: > Do you know of block devices with more than one? No, just defensive coding :-) > Nice, care to send a follow-on patch for this? Linus just pulled, so I generated it against his latest tree. lib/kobject.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/lib/kobject.c b/lib/kobject.c index 7444015..ce2cf43 100644 --- a/lib/kobject.c +++ b/lib/kobject.c @@ -224,8 +224,7 @@ static int kobject_set_name_vargs(struct kobject *kobj, const char *fmt, return -ENOMEM; /* ewww... some of these buggers have '/' in the name ... */ - s = strchr(kobj->name, '/'); - if (s) + while (s = strchr(kobj->name, '/')) s[0] = '!'; kfree(old_name); -- 1.5.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists