linux-kernel - Re: [patch 2.6.26-rc5] gpio: sysfs interface (updated)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080723000216.GB8203@kroah.com>
Date:	Tue, 22 Jul 2008 17:02:16 -0700
From:	Greg KH <greg@...ah.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	david-b@...bell.net, linux-kernel@...r.kernel.org,
	g.liakhovetski@...gutronix.de
Subject: Re: [patch 2.6.26-rc5] gpio: sysfs interface (updated)

On Tue, Jul 22, 2008 at 04:50:56PM -0700, Andrew Morton wrote:
> On Tue, 22 Jul 2008 16:28:24 -0700
> Greg KH <greg@...ah.com> wrote:
> 
> > On Tue, Jul 22, 2008 at 04:27:51PM -0700, Andrew Morton wrote:
> > > On Thu, 12 Jun 2008 11:53:36 -0700
> > > David Brownell <david-b@...bell.net> wrote:
> > > 
> > > > This adds a simple sysfs interface for GPIOs.
> > > 
> > > device_create_drvdata() has magically vanished from today's linux-next,
> > > so this code doesn't compile any more.
> > > 
> > > This:
> > > 
> > > --- a/drivers/gpio/gpiolib.c~gpio-sysfs-interface-updated-gpio-linux-next-fixes-for-sysfs-support-fix
> > > +++ a/drivers/gpio/gpiolib.c
> > > @@ -453,8 +453,8 @@ int gpio_export(unsigned gpio, bool dire
> > >  	if (status == 0) {
> > >  		struct device	*dev;
> > >  
> > > -		dev = device_create_drvdata(&gpio_class, desc->chip->dev, 0,
> > > -				desc, "gpio%d", gpio);
> > > +		dev = device_create(&gpio_class, desc->chip->dev, 0, desc,
> > > +					"gpio%d", gpio);
> > 
> > Should be NULL instead of 0 there, otherwise sparse will complain.
> 
> The third arg to device_create is a dev_t, so 0 is correct

Bah, sorry about that, MK_DEV(0,0) would be safer :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/