linux-kernel - Re: [patch 2.6.26-rc5] gpio: sysfs interface (updated)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080723001133.GA8592@kroah.com>
Date:	Tue, 22 Jul 2008 17:11:33 -0700
From:	Greg KH <greg@...ah.com>
To:	David Brownell <david-b@...bell.net>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, g.liakhovetski@...gutronix.de
Subject: Re: [patch 2.6.26-rc5] gpio: sysfs interface (updated)

On Tue, Jul 22, 2008 at 05:01:36PM -0700, David Brownell wrote:
> On Tuesday 22 July 2008, Greg KH wrote:
> > 
> > > device_create_drvdata() has magically vanished from today's linux-next,
> > > so this code doesn't compile any more.
> > > 
> > > This:
> > > 
> > > @@ -453,8 +453,8 @@ int gpio_export(unsigned gpio, bool dire
> > >       if (status == 0) {
> > >               struct device   *dev;
> > >  
> > > -             dev = device_create_drvdata(&gpio_class, desc->chip->dev, 0,
> > > -                             desc, "gpio%d", gpio);
> > > +             dev = device_create(&gpio_class, desc->chip->dev, 0, desc,
> > > +                                     "gpio%d", gpio);
> > 
> > Should be NULL instead of 0 there, otherwise sparse will complain.
> 
> The zero is a dev_t ... ??  (As Andrew just noted too.)
> 
> "desc" might need to be NULL, but it's a valid pointer
> (for driver_data).  I think this was a mental off-by-one...

Yes, you are correct, my mistake.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/