linux-kernel - Re: [stable] [patch 44/47] pxamci: fix byte aligned DMA transfers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Jul 2008 12:33:34 +0200
From:	"pHilipp Zabel" <philipp.zabel@...il.com>
To:	"Greg KH" <greg@...ah.com>
Cc:	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	"Greg KH" <gregkh@...e.de>, "Theodore Ts'o" <tytso@....edu>,
	"Zwane Mwaikambo" <zwane@....linux.org.uk>,
	"Justin Forbes" <jmforbes@...uxtx.org>,
	linux-kernel@...r.kernel.org,
	"Chris Wedgwood" <reviews@...cw.f00f.org>,
	"Domenico Andreoli" <cavokz@...il.com>, akpm@...ux-foundation.org,
	"Randy Dunlap" <rdunlap@...otime.net>, "Willy Tarreau" <w@....eu>,
	"Chuck Wolber" <chuckw@...ntumlinux.com>, alan@...rguk.ukuu.org.uk,
	"Chuck Ebbert" <cebbert@...hat.com>,
	"Dave Jones" <davej@...hat.com>, "Jake Edge" <jake@....net>,
	"Michael Krufky" <mkrufky@...uxtv.org>, stable@...nel.org,
	"Rodrigo Rubira Branco" <rbranco@...checkpoint.com>,
	"Pierre Ossman" <drzeus@...eus.cx>
Subject: Re: [stable] [patch 44/47] pxamci: fix byte aligned DMA transfers

On Wed, Jul 23, 2008 at 10:32 PM, Greg KH <greg@...ah.com> wrote:
> On Wed, Jul 23, 2008 at 01:24:12PM -0700, Linus Torvalds wrote:
>>
>>
>> On Wed, 23 Jul 2008, Greg KH wrote:
>>
>> > On Wed, Jul 23, 2008 at 09:01:34AM +0200, pHilipp Zabel wrote:
>> > >
>> > > There is an ugly typo in the patch below that was fixed by Karl Beldan:
>> > > http://git.kernel.org/?p=linux/kernel/git/drzeus/mmc.git;a=commit;h=28bbe535df5c461c25eb57affb30e007072429c3
>> > >
>> > > Not sure how you handle this, maybe this patch should only go in
>> > > together with the other.
>> >
>> > As the above mentioned patch isn't in Linus's tree yet, I can't take it.
>> >
>> > Care to send it to stable@...nel.org when it does go in?  Or is this
>> > current patch just broken without it and not worth adding at all?
>>
>> Hmm. I think it's commit 4fe16897c59882420d66f2d503106653d026ed6c
>> upstream. I don't know why it has a different SHA1 in the mmc tree, but I
>> assume that it's because the MMC tree has rebased at some point. Ugh.

Thank you, I think when I wrote my mail it wasn't pulled yet.

> Ah, thanks, I missed that.
>
> Hm, that is added post 2.6.26, so I'll add this fixup patch to the
> .25-stable tree, and also add this one to the .26-stable queue.

Ok, thank you.

> Philipp, is that correct, or does this original one also need to get
> added to the .26-stable queue as well?

AFAICT, the original one (97f8571e663c808ad2d01a396627235167291556) is
post-26, too.

Both should be applied together. Although it is unlikely that with the
broken patch MMC accesses will accidentally clear the DALGN bits of
other running (unaligned) DMA chains (I'm not aware of any drivers
using unaligned DMA), the PXA27x developer manual says that this "must
not" be done. If it would result in memory corruption or lockups, I
don't know.

regards
Philipp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/