linux-kernel - Re: [PATCH] x86 (64): make calibrate_APIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Jul 2008 09:31:48 -0400
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Martin Wilck <martin.wilck@...itsu-siemens.com>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Wichert, Gerhard" <Gerhard.Wichert@...itsu-siemens.com>
Subject: Re: [PATCH] x86 (64): make calibrate_APIC_clock() smp-safe

Martin Wilck wrote:
> Hi Thomas and Peter, hi everyone,
> 
> Asynchrounous events (e.g.SMIs) which occur during the APIC timer 
> calibration can cause timer miscalibrations, sometimes by large amounts.
> 
> This patch fixes this by two separate measures:
>   a) make sure that no significant interruption occurs between APIC and
>      TSC reads
>   b) make sure that the measurement loop isn't significantly longer
>      than originally intended.
> 
> I am sorry, due to a misconfiguration of our SMTP server I need to send 
> the patch as attachment.
> 

The other thing we may want to consider is doing multiple runs of the 
calibration loop.  I suspect we'd get a more accurate result running, 
say, 9 loops of the 1/9 the current duration and looking either for the 
best result or the median (NOT the mean.)

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/