linux-kernel - Re: [PATCH 2/2] xen-netfront: call netif_start_queue() on xennet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Jul 2008 08:45:59 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Eduardo Habkost <ehabkost@...hat.com>
CC:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	NetDev <netdev@...r.kernel.org>, Jeff Garzik <jeff@...zik.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH 2/2] xen-netfront: call netif_start_queue() on xennet_open()

Eduardo Habkost wrote:
> xen-netfront was waking the queue before calling netif_start_queue(),
> triggering the BUG_ON() on __netif_schedule().
>
> Signed-off-by: Eduardo Habkost <ehabkost@...hat.com>
>   
Ok,
Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>

but Ingo, do you want to pick this up?  You're gathering a collection of 
these patches anyway, or should we kick it over to Dave/Jeff?

    J

> ---
>  drivers/net/xen-netfront.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> index 902bbe7..c749bdb 100644
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -329,7 +329,7 @@ static int xennet_open(struct net_device *dev)
>  	}
>  	spin_unlock_bh(&np->rx_lock);
>  
> -	xennet_maybe_wake_tx(dev);
> +	netif_start_queue(dev);
>  
>  	return 0;
>  }
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/