linux-kernel - Re: [PATCH] bcm5974-0.58: name changes, open/close and suspend/resume serialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080725154250.GA1861@anvil.corenet.prv>
Date:	Fri, 25 Jul 2008 11:42:50 -0400
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Henrik Rydberg <rydberg@...omail.se>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	robfitz@...k.net, akpm@...l.org, jikos@...os.cz, vojtech@...e.cz,
	dmonakhov@...nvz.org, johannes@...solutions.net
Subject: Re: [PATCH] bcm5974-0.58: name changes, open/close and
	suspend/resume serialized

Hi Henrik,

On Thu, Jul 24, 2008 at 09:37:02AM +0200, Henrik Rydberg wrote:
> 
> This is version bcm5974-0.58. Changes since 0.57 are in short:
> 
>   * Name changes; use usbhid definitions, rename atp to bcm5974
>   * Input syncing moved to report functions, event type setup broken out
>   * Traffic functions added for open/close and suspend/resume logic
>   * Open/close and suspend/resume transition logic corrected
>   * Open/close serialized with respect to suspend/resume
> 

Thank you for the changes.  You don't have to track whether device is
manually suspended or not - usb_submit_urb will fail and that is it.

Attached are 2 patches. First cleans suspend state tracking as it is not
really needed and does some formatting and other minor changes and 2nd
implements runtime pm for the device. Could you please try them and if
everything still works I will apply the driver.

Thanks!

-- 
Dmitry

View attachment "bcm5974-cleanups.patch" of type "text/plain" (13648 bytes)

View attachment "bcm5974-autopm.patch" of type "text/plain" (1910 bytes)