[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080728174437.GA29795@sgi.com>
Date: Mon, 28 Jul 2008 12:44:37 -0500
From: Jack Steiner <steiner@....com>
To: unlisted-recipients:; (no To-header on input)
Cc: Nick Piggin <npiggin@...e.de>,
Andrew Morton <akpm@...ux-foundation.org>,
Linux Memory Management List <linux-mm@...ck.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: GRU driver feedback
Whoops:
>
> - In gru_fault, I don't think you've validated the size of the vma, and it
> definitely seems like you haven't taken offset into the vma into account
> either. remap_pfn_range etc should probably validate the former because I'm
> sure this isn't the only driver that might get it wrong. The latter can't
> really be detected though. Please fix or make it more obviously correct (eg
> a comment).
ZZZ
s/ZZZ/fixed/
--- jack
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists