linux-kernel - Re: [PATCH] ACPI/CPUIDLE: prevent setting pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080728174644.GC30344@one.firstfloor.org>
Date:	Mon, 28 Jul 2008 19:46:44 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Dhaval Giani <dhaval@...ux.vnet.ibm.com>,
	Venkatesch Pallipadi <venkatesh.pallipadi@...el.com>,
	Len Brown <lenb@...nel.org>, Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH] ACPI/CPUIDLE: prevent setting pm_idle to NULL

> +	/*
> +	 * Fall back to the default idle loop, when pm_idle_save had
> +	 * been initialized.
> +	 */
> +	if (pm_idle_save) {
> +		pm_idle = pm_idle_save;
> +		/* Relies on interrupts forcing exit from idle. */
> +		synchronize_sched();
> +	}

I think it would be better to fall  back to default_idle (which
might need to be exported) when the old pointer is NULL. Now with your patch 
the cpuidle idle code would run with inconsistent state for some time,
which is probably not good.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/