linux-kernel - Re: [PATCH] mISDN cleanup user interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Jul 2008 20:46:03 +0200
From:	Karsten Keil <kkeil@...e.de>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	isdn4linux@...tserv.isdn4linux.de,
	Marcel Holtmann <marcel@...tmann.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mISDN cleanup user interface

On Wed, Jul 30, 2008 at 08:37:21PM +0200, Sam Ravnborg wrote:
> On Wed, Jul 30, 2008 at 07:51:38PM +0200, Karsten Keil wrote:
> > On Wed, Jul 30, 2008 at 05:57:01PM +0100, David Woodhouse wrote:
> > > On Wed, 2008-07-30 at 18:33 +0200, Karsten Keil wrote:
> > > > What about this implementation ?
> > > 
> > > Looks a lot saner... although it does seem to confirm my earlier
> > > suspicion that you're not even _using_ the fact that it's a bitmap at
> > > all. You set the bits for the present channels at init time, which are
> > > always contiguous, and you never seem to change them them later -- why
> > > couldn't you do this with a simple 'number of channels' integer?
> > 
> > No it is not contineous on different PRI line setups (E1,T1 ...)
> > e.g a E1 has the D-channel on channel 15 position, so this bit is not set
> > then.
> timeslot 16 in my book actually - but maybe that your timeslot to
> channel mapping.
> 

You are correct of course.

-- 
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/