linux-kernel - Re: [patch 2/4] vfs: filp is never NULL in do_generic_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080731161554.3C84.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Date:	Thu, 31 Jul 2008 16:19:08 +0900
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	kosaki.motohiro@...fujitsu.com, viro@...IV.linux.org.uk,
	akpm@...ux-foundation.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 2/4] vfs: filp is never NULL in do_generic_file_read()

>  	*ppos = ((loff_t)index << PAGE_CACHE_SHIFT) + offset;
> -	if (filp)
> -		file_accessed(filp);
> +	file_accessed(filp);
>  }
>  
>  int file_read_actor(read_descriptor_t *desc, struct page *page,

if filp is never NULL, BUG_ON is better?




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/