linux-kernel - Switching TestSetPageLocked to trylock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <200807311726.51816.nickpiggin@yahoo.com.au>
Date:	Thu, 31 Jul 2008 17:26:51 +1000
From:	Nick Piggin <nickpiggin@...oo.com.au>
To:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Switching TestSetPageLocked to trylock_page

Hi,

I'm wondering if I could get a patch merged which changes all
TestSetPageLocked and replaces them with trylock_page?

It would be done so there are no functional changes.

The reason I want to (aside from having a slightly more
intuitive API), is to facilitate the implementation of lockdep
on page lock, and also to use lock semantics bitops for the
lock rather than the big-hammer barriers that come with
test_and_set_bit.

The lock bitops stuff is one of the parts of my patchset to speed
up page lock functions (which results in nearly 50% faster
pagecache throughput on my G5, and even slightly faster on x86)...

Anyway, I remember you said these kinds of changes are appropriate
for just after -rc1, and I agree it shouldn't cause much pain.

Fixing up patch conflicts is literally a matter of
s/!TestSetPageLocked/trylock_page
s/TestSetPageLocked/!trylock_page

Thoughts?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/