linux-kernel - Re: [patch resend] vfs: move executable checking into ->permission()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 31 Jul 2008 17:10:24 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	akpm@...ux-foundation.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [patch resend] vfs: move executable checking into
	->permission()

On Thu, Jul 31, 2008 at 01:41:58PM +0200, Miklos Szeredi wrote:
> On Thu, 31 Jul 2008, Al Viro wrote:
> > On Wed, Jul 30, 2008 at 03:02:03PM +0200, Miklos Szeredi wrote:
> > >  static int coda_ioctl_permission(struct inode *inode, int mask)
> > >  {
> > > -        return 0;
> > > +	return check_execute(dentry->d_inode, mask);
> > >  }
> > 
> > Er?
> > 	a) mismerge from dentry-based variant
> 
> Yeah, crappy patch.  Agree on all other comments as well, thanks for
> the review.
 
Hrm...  OK, behaviour change for permission() on bdev/cdev/pipe is
not a problems...

I'll apply it, but if anybody has better suggestions for helper name,
please yell.  "execute_ok()" sounds very odd...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/