linux-kernel - Re: [PATCH] Removes extra checking in kernel/cpuset.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080731111522.6417f750.pj@sgi.com>
Date:	Thu, 31 Jul 2008 11:15:22 -0500
From:	Paul Jackson <pj@....com>
To:	"Rakib Mullick" <rakib.mullick@...il.com>
Cc:	menage@...gle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Removes extra checking in kernel/cpuset.c

Rakib wrote:
> Hello guys, this patch removes an extra checking over 'cs' in
> functions 'guarantee_online_cpus' and 'guarantee_online_mems'.
> ...
> -	while (cs && !cpus_intersects(cs->cpus_allowed, cpu_online_map))
> -		cs = cs->parent;
> -	if (cs)
> +	if (cs) {
> +		while (!cpus_intersects(cs->cpus_allowed, cpu_online_map))
> +			cs = cs->parent;

I don't think that works - "cs->parent" can be NULL, and will be NULL
if cs is the root cpuset.

So we must check for non-NULL cs each step of the way back up the
cpuset tree.

I must NAQ this patch.

Holler if you think I'm missing something.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@....com> 1.940.382.4214
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/