linux-kernel - Re: [PATCH, RFC] A development process document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080731101738.1bf4281c@bike.lwn.net>
Date:	Thu, 31 Jul 2008 10:17:38 -0600
From:	Jonathan Corbet <corbet@....net>
To:	Alex Chiang <achiang@...com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Amanda McPherson <amanda@...pherson.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH, RFC] A development process document

On Thu, 31 Jul 2008 00:23:05 -0600
Alex Chiang <achiang@...com> wrote:

> Overall, a great document, as expected from you. I've replied with
> "content" comments below.

I've applied most of them, thanks.
 
> But it occurs to me that sending "style" comments to the editor of
> LWN is something akin to, well, some combination of Prometheus,
> Icarus, ravenous vultures, rabid penguins, and telling Linus that
> his choice of $EDITOR sucks, which is to say, "unwise".

Naw, English always needs debugging too.
 
> You've got url reference for some quotes but not all. Would it be
> possible to track them all down? Sorry for asking for all the extra
> work, but I think the references are useful, especially if the
> motivated reader actually visits said reference and gets all sides of
> the story.

I'll see what I can do.  Some of the older ones are kind of hard to find. 
 
> > +Patches must be prepared against a specific version of the
> > kernel.  As a +general rule, a patch should be based on the current
> > mainline as found in +Linus's git tree.  It may become necessary to
> > make versions against -mm,
>    ^^^^^^^
> Hm, is this the new recommended style? Grammar school taught me that
> it should be "Linus'" but I've noticed a gradually changing but
> inconsistently applied new school style.

I actually researched that a while back.  The rule, as far as I can tell
(and to the extent that English has real rules) is that the trailing "s" is
elided only when making a possessive of a plural noun.  "Linus", being very
much a unique, singular entity, needs to be "Linus's" in the possessive
form.
 
> > +If you have a significant series of patches, it is customary to
> > send an +introductory description as part zero.  In general, the
> > second and
> 
> This directly conflicts with akpm's advice:
> 
> 	http://www.zipworld.com.au/~akpm/linux/patches/stuff/tpp.txt
> 
> Section 6(b).

Interesting; Andrew didn't mention that in his review.  I think the intro
postings can be very useful in understanding a patch series as a whole.
Maybe I'll put in something about how anything which should be in the
changelogs needs to go with the actual patches.

Thanks,

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/