linux-kernel - Re: [PATCH] Introduce down_try() so we can move away from down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0808011022230.3277@nehalem.linux-foundation.org>
Date:	Fri, 1 Aug 2008 10:26:33 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Rusty Russell <rusty@...tcorp.com.au>
cc:	Paul Menage <menage@...gle.com>, linux-kernel@...r.kernel.org,
	Matthew Wilcox <matthew@....cx>,
	"Randy.Dunlap" <rdunlap@...otime.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH] Introduce down_try() so we can move away from
 down_trylock()

On Tue, 29 Jul 2008, Rusty Russell wrote:
> 
> Introduce down_try()

I hate that name. Everybody else uses "xxx_trylock()", now you introduce a 
short version of that that just has the same return value as everybody 
else except for semaphores that admittedly were odd.

Also, all actual _users_ of down_trylock() seem to be prime candidates for 
turning into mutexes anyway - with the _possible_ exception of the console 
semaphore which has problems with the mutex debugging code.

> I planned on removing the much-disliked down_trylock() (with its
> backwards return codes) in 2.6.27, but it's creating something of a
> logjam with other patches in -mm and linux-next.
> 
> Andrew suggested introducing "down_try" as a wrapper now, to make
> the transition easier.

The transition to WHAT? To crap?

There is no need to introduce yet another temporary thing just to make 
things even _more_ confusing.

Yeah, I'm grumpy. I'm always pretty grumpy, but I'm trying to go through 
some backlog where I had been going "hmm, why would I do this", and this 
one wasn't the only one where my reaction was "if I pull/apply this, the 
end result is worse".

Guys, some quality control and critical thinking, please.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/