linux-kernel - Re: [PATCH] Introduce down_try() so we can move away from down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080801104046.e9e8d6fd.akpm@linux-foundation.org>
Date:	Fri, 1 Aug 2008 10:40:46 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	Paul Menage <menage@...gle.com>, linux-kernel@...r.kernel.org,
	Matthew Wilcox <matthew@....cx>,
	"Randy.Dunlap" <rdunlap@...otime.net>,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH] Introduce down_try() so we can move away from
 down_trylock()

On Fri, 1 Aug 2008 10:26:33 -0700 (PDT) Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> > I planned on removing the much-disliked down_trylock() (with its
> > backwards return codes) in 2.6.27, but it's creating something of a
> > logjam with other patches in -mm and linux-next.
> > 
> > Andrew suggested introducing "down_try" as a wrapper now, to make
> > the transition easier.
> 
> The transition to WHAT? To crap?
> 

The naming is pretty sad, but the inconsistent return value from
down_trylock() drives me batshit.  It means that every time I ever look
at any sort of trylock call I need to go back to the definition site to
work out if it's the one which returns true or if it's the one which
returns false.

It would be good to get that fixed.  And if we _do_ want to fix it, I
don't see any alternative to creating a new function.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/