linux-kernel - Re: [RFC, 2.6.26.2-rc1] fs/partition/check.c: fix return value warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 2 Aug 2008 22:09:29 +0200
From:	"Oliver Pinter" <oliver.pntr@...il.com>
To:	"Willy Tarreau" <w@....eu>
Cc:	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	"Abdel Benamrouche" <draconux@...il.com>, stable@...nel.org,
	jens.axboe@...cle.com, "Andrew Morton" <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC, 2.6.26.2-rc1] fs/partition/check.c: fix return value warning

Willy, this good to know ...

and I think, this patch fixed a small leak:

+
+out2:
+       device_del(&p->dev);
+out1:
+       put_device(&p->dev);
+       free_part_stats(p);
+out0:
+       kfree(p);
+       return err;


On 8/2/08, Willy Tarreau <w@....eu> wrote:
> On Sat, Aug 02, 2008 at 12:56:10PM -0700, Linus Torvalds wrote:
>> Please don't just send patches to the stable team because they "look
>> fine". They should be real bugs, with real consequences. And no, a
>> compiler warning is not a real consequence.
>
> BTW, before Oliver does the mistake, I'd suggest never forwarding
> network patches to stable either as Davem already maintains his
> own -stable queue ;-)
>
> Willy
>
>


-- 
Thanks,
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/