linux-kernel - Re: [RFC, 2.6.26.2-rc1] posix timers: release_posix_timer: kill the bogus put_task_struct(->it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 3 Aug 2008 14:37:55 +0400
From:	Oleg Nesterov <oleg@...sign.ru>
To:	Sven Wegener <sven.wegener@...aler.net>
Cc:	Oliver Pinter <pinter.oliver.villany@...il.com>,
	linux-kernel@...r.kernel.org, w@....eu,
	Roland McGrath <roland@...hat.com>,
	john stultz <johnstul@...ibm.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Oliver Pinter <oliver.pntr@...il.com>
Subject: Re: [RFC, 2.6.26.2-rc1] posix timers: release_posix_timer: kill the bogus put_task_struct(->it_process)

On 08/03, Sven Wegener wrote:
>
> On Sat, 2 Aug 2008, Oliver Pinter wrote:
> 
> > It is an RFC for sending this patch for stable, when this patch needed, then send ACK and CC stable,
> > if not then send NAK.
> 
> I'd say big NAK. Have you ever looked at the full commit message and patch 
> at all? It says "release_posix_timer() can't be called with ->it_process 
> != NULL.". Point. The rest is the explanation why this can't happen. And 
> looking at the patch, we see that it just removes code that actually never 
> gets executed under the mentioned preconditions. It's a pure cleanup patch 
> and doesn't qualify for -stable. Same goes for the other posix timer patch 
> you mailed out.

I agree. Perhaps the changelog was badly written...

These 2 patches are just cleanups which remove the dead code,
this is not the -stable material.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/