linux-kernel - Re: [RFC, 2.6.26.2-rc1] signals: do_signal_stop: kill the SIGNAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080803105338.GB79@tv-sign.ru>
Date:	Sun, 3 Aug 2008 14:53:38 +0400
From:	Oleg Nesterov <oleg@...sign.ru>
To:	oliver.pntr@...il.com
Cc:	stable@...nel.org, Roland McGrath <roland@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC, 2.6.26.2-rc1] signals: do_signal_stop: kill the SIGNAL_UNKILLABLE check

On 08/02, Oliver Pinter wrote:
>
> >From 2b201a9eddf509e8e935b45e573648e36f4b623f Mon Sep 17 00:00:00 2001
> From: Oleg Nesterov <oleg@...sign.ru>
> Date: Fri, 25 Jul 2008 01:47:31 -0700
> Subject: [PATCH] signals: do_signal_stop: kill the SIGNAL_UNKILLABLE check
> 
> [ Upstream commit 2b201a9eddf509e8e935b45e573648e36f4b623f ]
> 
> fae5fa44f1fd079ffbed8e0add929dd7bbd1347f changed do_signal_stop() to check
> SIGNAL_UNKILLABLE, this wasn't needed.  If signal_group_exit() == F, the
> signal sent to SIGNAL_UNKILLABLE task must be already filtered out by the
> caller, get_signal_to_deliver().  And if signal_group_exit() == T we are
> not going to stop.
> 
> Signed-off-by: Oleg Nesterov <oleg@...sign.ru>
> Acked-by: Roland McGrath <roland@...hat.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
> CC: Oliver Pinter <oliver.pntr@...il.com>
> 
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 15f901a..0514da5 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -1649,8 +1649,7 @@ static int do_signal_stop(int signr)
>  	} else {
>  		struct task_struct *t;
>  
> -		if (unlikely((sig->flags & (SIGNAL_STOP_DEQUEUED | SIGNAL_UNKILLABLE))
> -					 != SIGNAL_STOP_DEQUEUED) ||
> +		if (!likely(sig->flags & SIGNAL_STOP_DEQUEUED) ||

Again, I don't think this minor cleanup is good for -stable.

It doesn't fix any bug, it only removes the unnecessary uglification (which
was previously added by me in fae5fa44f1fd079ffbed8e0add929dd7bbd1347f).

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/