linux-kernel - Re: [PATCH] x86, acpi: temp_stack is used only when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.1.10.0808031901120.7765@titan.stealer.net>
Date:	Sun, 3 Aug 2008 19:07:30 +0200 (CEST)
From:	Sven Wegener <sven.wegener@...aler.net>
To:	Marcin Slusarz <marcin.slusarz@...il.com>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Glauber Costa <gcosta@...hat.com>,
	Pavel Machek <pavel@...e.cz>, Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] x86, acpi: temp_stack is used only when CONFIG_SMP is
 set

On Sun, 3 Aug 2008, Marcin Slusarz wrote:

> arch/x86/kernel/acpi/sleep.c:24: warning: 'temp_stack' defined but not used
> 
> Signed-off-by: Marcin Slusarz <marcin.slusarz@...il.com>
> Cc: Glauber Costa <gcosta@...hat.com>
> Cc: Pavel Machek <pavel@...e.cz>
> Cc: Ingo Molnar <mingo@...e.hu>
> ---
>  arch/x86/kernel/acpi/sleep.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c
> index fa2161d..9103cb6 100644
> --- a/arch/x86/kernel/acpi/sleep.c
> +++ b/arch/x86/kernel/acpi/sleep.c
> @@ -20,7 +20,7 @@ unsigned long acpi_realmode_flags;
>  /* address in low memory of the wakeup routine. */
>  static unsigned long acpi_realmode;
>  
> -#ifdef CONFIG_64BIT
> +#ifdef CONFIG_SMP
>  static char temp_stack[10240];
>  #endif
>  

Now it still generates the warning, but on i386 with CONFIG_SMP set, 
instead of x86_64 without CONFIG_SMP. We only need temp_stack, when both 
CONFIG_64BIT and CONFIG_SMP are activated.

Sven
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/