linux-kernel - Re: [PATCH] x86, acpi: temp_stack is used only when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080803172535.GE5414@joi>
Date:	Sun, 3 Aug 2008 19:25:48 +0200
From:	Marcin Slusarz <marcin.slusarz@...il.com>
To:	Sven Wegener <sven.wegener@...aler.net>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Glauber Costa <gcosta@...hat.com>,
	Pavel Machek <pavel@...e.cz>, Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] x86, acpi: temp_stack is used only when CONFIG_SMP is
	set

On Sun, Aug 03, 2008 at 07:07:30PM +0200, Sven Wegener wrote:
> On Sun, 3 Aug 2008, Marcin Slusarz wrote:
> 
> > arch/x86/kernel/acpi/sleep.c:24: warning: 'temp_stack' defined but not used
> > 
> > Signed-off-by: Marcin Slusarz <marcin.slusarz@...il.com>
> > Cc: Glauber Costa <gcosta@...hat.com>
> > Cc: Pavel Machek <pavel@...e.cz>
> > Cc: Ingo Molnar <mingo@...e.hu>
> > ---
> >  arch/x86/kernel/acpi/sleep.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c
> > index fa2161d..9103cb6 100644
> > --- a/arch/x86/kernel/acpi/sleep.c
> > +++ b/arch/x86/kernel/acpi/sleep.c
> > @@ -20,7 +20,7 @@ unsigned long acpi_realmode_flags;
> >  /* address in low memory of the wakeup routine. */
> >  static unsigned long acpi_realmode;
> >  
> > -#ifdef CONFIG_64BIT
> > +#ifdef CONFIG_SMP
> >  static char temp_stack[10240];
> >  #endif
> >  
> 
> Now it still generates the warning, but on i386 with CONFIG_SMP set, 
> instead of x86_64 without CONFIG_SMP. We only need temp_stack, when both 
> CONFIG_64BIT and CONFIG_SMP are activated.

Yes. Thanks for looking at the patch!

---
>From c6e673acf02e8bf04866cadf17c1cb1fa4d852ea Mon Sep 17 00:00:00 2001
From: Marcin Slusarz <marcin.slusarz@...il.com>
Subject: [PATCH] x86, acpi: temp_stack is used only when CONFIG_64BIT && CONFIG_SMP is set

arch/x86/kernel/acpi/sleep.c:24: warning: 'temp_stack' defined but not used

Signed-off-by: Marcin Slusarz <marcin.slusarz@...il.com>
Cc: Glauber Costa <gcosta@...hat.com>
Cc: Pavel Machek <pavel@...e.cz>
Cc: Ingo Molnar <mingo@...e.hu>
Cc: Sven Wegener <sven.wegener@...aler.net>
---
 arch/x86/kernel/acpi/sleep.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c
index fa2161d..81e5ab6 100644
--- a/arch/x86/kernel/acpi/sleep.c
+++ b/arch/x86/kernel/acpi/sleep.c
@@ -20,7 +20,7 @@ unsigned long acpi_realmode_flags;
 /* address in low memory of the wakeup routine. */
 static unsigned long acpi_realmode;
 
-#ifdef CONFIG_64BIT
+#if defined(CONFIG_SMP) && defined(CONFIG_64BIT)
 static char temp_stack[10240];
 #endif
 
-- 
1.5.4.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/