linux-kernel - Re: [PATCH 3/5] x86: Coding style fixes to arch/x86/lib/strstr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48969F99.1060301@movial.fi>
Date:	Mon, 04 Aug 2008 09:20:09 +0300
From:	Dmitri Vorobiev <dmitri.vorobiev@...ial.fi>
To:	Paolo Ciarrocchi <paolo.ciarrocchi@...il.com>
CC:	Ingo Molnar <mingo@...e.hu>, hpa <hpa@...or.com>,
	tglx <tglx@...utronix.de>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/5] x86: Coding style fixes to arch/x86/lib/strstr_32.c

Paolo Ciarrocchi wrote:
> Before:
> total: 3 errors, 0 warnings, 31 lines checked
> 
> After:
> total: 0 errors, 0 warnings, 31 lines checked
> 
> paolo@...lo-desktop:~/linux.trees.git$ md5sum /tmp/strstr_32.o.*

It seems very tempting to merge this file with arch/x86/lib/string_32.c, or is there any compelling reason to keep these two separate?

> c96006ec3387862e5bacb139207a3098  /tmp/strstr_32.o.after
> c96006ec3387862e5bacb139207a3098  /tmp/strstr_32.o.before
> 
> Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@...il.com>
> ---
>  arch/x86/lib/strstr_32.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/lib/strstr_32.c b/arch/x86/lib/strstr_32.c
> index 42e8a50..8e2d55f 100644
> --- a/arch/x86/lib/strstr_32.c
> +++ b/arch/x86/lib/strstr_32.c
> @@ -23,9 +23,9 @@ __asm__ __volatile__(
>  	"jne 1b\n\t"
>  	"xorl %%eax,%%eax\n\t"
>  	"2:"
> -	:"=a" (__res), "=&c" (d0), "=&S" (d1)
> -	:"0" (0), "1" (0xffffffff), "2" (cs), "g" (ct)
> -	:"dx", "di");
> +	: "=a" (__res), "=&c" (d0), "=&S" (d1)
> +	: "0" (0), "1" (0xffffffff), "2" (cs), "g" (ct)
> +	: "dx", "di");
>  return __res;

It's strange that checkpatch.pl does not cater for such an obvious style violation as this last line.

Dmitri

>  }
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/