[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080804174128.a0877c27.akpm@linux-foundation.org>
Date: Mon, 4 Aug 2008 17:41:28 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: "Yang, Bo" <Bo.Yang@....com>
Cc: "'James.Bottomley@...elEye.com'" <James.Bottomley@...elEye.com>,
"'linux-scsi@...r.kernel.org'" <linux-scsi@...r.kernel.org>,
"'akpm@...l.org'" <akpm@...uxfoundation.org>,
"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
"Patro, Sumant" <Sumant.Patro@....com>,
"Austria, Winston" <Winston.Austria@....com>,
"poswald@...ell.com" <poswald@...ell.com>
Subject: Re: [PATCH 1/4] scsi: megaraid_sas - Add the dumy readl to force
PCI flush
On Fri, 1 Aug 2008 10:19:07 -0600 "Yang, Bo" <Bo.Yang@....com> wrote:
> MegaRAID SAS Driver get unexpected Interrupt. Add the dumy readl to force PCI flush will fix this issue.
>
> Signed-off-by Bo Yang<bo.yang@....com>
>
> ---
> drivers/scsi/megaraid/megaraid_sas.c | 6 ++++++
> 1 files changed, 6 insertions(+)
>
> diff -rupN linux-2.6.28_orig/drivers/scsi/megaraid/megaraid_sas.c linux-2.6.28_new/drivers/scsi/megaraid/megaraid_sas.c
> --- linux-2.6.28_orig/drivers/scsi/megaraid/megaraid_sas.c 2008-07-31 12:00:58.000000000 -0400
> +++ linux-2.6.28_new/drivers/scsi/megaraid/megaraid_sas.c 2008-07-31 12:30:35.000000000 -0400
> @@ -198,6 +198,9 @@ megasas_clear_intr_xscale(struct megasas
> */
> writel(status, ®s->outbound_intr_status);
>
> + /* Dummy readl to force pci flush */
> + readl(®s->outbound_intr_status);
> +
> return 0;
> }
>
> @@ -293,6 +296,9 @@ megasas_clear_intr_ppc(struct megasas_re
> */
> writel(status, ®s->outbound_doorbell_clear);
>
> + /* Dummy readl to force pci flush */
> + readl(®s->outbound_doorbell_clear);
> +
> return 0;
> }
> /**
These patches all had their tabs replaced with spaces. I fixed them up.
Please always run checkpatch on all patches. checkpatch found this:
ERROR: Macros with complex values should be enclosed in parenthesis
#182: FILE: drivers/scsi/megaraid/megaraid_sas.h:586:
+#define MFI_GEN2_ENABLE_INTERRUPT_MASK 0x00000001 | 0x00000004
which is a potential source of bugs. I queued a patch to fix that also.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists