linux-kernel - RE: [PATCH 1/4] scsi: megaraid_sas - Add the dumy readl to force PCI flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Aug 2008 06:27:10 -0600
From:	"Yang, Bo" <Bo.Yang@....com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	"'James.Bottomley@...elEye.com'" <James.Bottomley@...elEye.com>,
	"'linux-scsi@...r.kernel.org'" <linux-scsi@...r.kernel.org>,
	"'akpm@...l.org'" <akpm@...uxfoundation.org>,
	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
	"Patro, Sumant" <Sumant.Patro@....com>,
	"Austria, Winston" <Winston.Austria@....com>,
	"poswald@...ell.com" <poswald@...ell.com>
Subject: RE: [PATCH 1/4] scsi: megaraid_sas - Add the dumy readl to force
 PCI flush

Thanks Andrew.

Bo Yang

________________________________________
From: Andrew Morton [akpm@...ux-foundation.org]
Sent: Monday, August 04, 2008 8:41 PM
To: Yang, Bo
Cc: 'James.Bottomley@...elEye.com'; 'linux-scsi@...r.kernel.org'; 'akpm@...l.org'; 'linux-kernel@...r.kernel.org'; Patro, Sumant; Austria, Winston; poswald@...ell.com
Subject: Re: [PATCH 1/4] scsi: megaraid_sas - Add the dumy readl to force PCI flush

On Fri, 1 Aug 2008 10:19:07 -0600 "Yang, Bo" <Bo.Yang@....com> wrote:

> MegaRAID SAS Driver get unexpected Interrupt.  Add the dumy readl to force PCI flush will fix this issue.
>
> Signed-off-by Bo Yang<bo.yang@....com>
>
> ---
> drivers/scsi/megaraid/megaraid_sas.c |    6 ++++++
> 1 files changed, 6 insertions(+)
>
> diff -rupN linux-2.6.28_orig/drivers/scsi/megaraid/megaraid_sas.c linux-2.6.28_new/drivers/scsi/megaraid/megaraid_sas.c
> --- linux-2.6.28_orig/drivers/scsi/megaraid/megaraid_sas.c      2008-07-31 12:00:58.000000000 -0400
> +++ linux-2.6.28_new/drivers/scsi/megaraid/megaraid_sas.c       2008-07-31 12:30:35.000000000 -0400
> @@ -198,6 +198,9 @@ megasas_clear_intr_xscale(struct megasas
>          */
>         writel(status, &regs->outbound_intr_status);
>
> +       /* Dummy readl to force pci flush */
> +       readl(&regs->outbound_intr_status);
> +
>         return 0;
>  }
>
> @@ -293,6 +296,9 @@ megasas_clear_intr_ppc(struct megasas_re
>          */
>         writel(status, &regs->outbound_doorbell_clear);
>
> +       /* Dummy readl to force pci flush */
> +       readl(&regs->outbound_doorbell_clear);
> +
>         return 0;
>  }
>  /**

These patches all had their tabs replaced with spaces.  I fixed them up.

Please always run checkpatch on all patches.  checkpatch found this:

ERROR: Macros with complex values should be enclosed in parenthesis
#182: FILE: drivers/scsi/megaraid/megaraid_sas.h:586:
+#define MFI_GEN2_ENABLE_INTERRUPT_MASK         0x00000001 | 0x00000004

which is a potential source of bugs.  I queued a patch to fix that also.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/