linux-kernel - Re: [PATCH 1/3] powerpc - Initialize the irq radix tree earlier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1217898303.24157.122.camel@pasglop>
Date:	Tue, 05 Aug 2008 11:05:03 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Sebastien Dugue <sebastien.dugue@...l.net>
Cc:	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org,
	linux-rt-users@...r.kernel.org, paulus@...ba.org,
	michael@...erman.id.au, jean-pierre.dion@...l.net,
	gilles.carry@....bull.net, tinytim@...ibm.com, tglx@...utronix.de,
	rostedt@...dmis.org
Subject: Re: [PATCH 1/3] powerpc - Initialize the irq radix tree earlier


>  - Remove the populating of the tree from the revmap function as
>    you already do
>  - Move it to irq_create_mapping() for the normal case
>  - For pre-existing interrupt, have the generic code that initializes
>    the radix tree walk through all interrupts and setup the revmap for
>    them. If that needs locking vs. concurrent irq_create_mapping, it's
>    easy to use one of the available spinlocks for that.

And in fact, you may even be able to avoid GFP_ATOMIC completely here
and switch it to GFP_KERNEL since irq_create_mapping() can sleep afaik,
provided that you avoid the spinlocking.

Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/