linux-kernel - Re: [PATCH] memcg: fix oops in mem_cgroup_shrink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15853594.1218039196773.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Thu, 7 Aug 2008 01:13:16 +0900 (JST)
From:	kamezawa.hiroyu@...fujitsu.com
To:	Hugh Dickins <hugh@...itas.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] memcg: fix oops in mem_cgroup_shrink_usage

----- Original Message -----
>Date: 	Wed, 6 Aug 2008 15:15:08 +0100 (BST)
>From: Hugh Dickins <hugh@...itas.com>
>To: Andrew Morton <akpm@...ux-foundation.org>
>cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
>   Balbir Singh <balbir@...ux.vnet.ibm.com>, linux-kernel@...r.kernel.org
>Subject: [PATCH] memcg: fix oops in mem_cgroup_shrink_usage
>
>
>Got an oops in mem_cgroup_shrink_usage() when testing loop over tmpfs:
>yes, of course, loop0 has no mm: other entry points check but this didn't.
>
>Signed-off-by: Hugh Dickins <hugh@...itas.com>

Ahh, thank you!

-Kame

>---
>
> mm/memcontrol.c |    2 ++
> 1 file changed, 2 insertions(+)
>
>--- 2.6.27-rc2/mm/memcontrol.c	2008-08-06 08:36:20.000000000 +0100
>+++ linux/mm/memcontrol.c	2008-08-06 09:05:26.000000000 +0100
>@@ -796,6 +796,8 @@ int mem_cgroup_shrink_usage(struct mm_st
> 
> 	if (mem_cgroup_subsys.disabled)
> 		return 0;
>+	if (!mm)
>+		return 0;
> 
> 	rcu_read_lock();
> 	mem = mem_cgroup_from_task(rcu_dereference(mm->owner));
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/