linux-kernel - Re: [PATCH] memcg: fix oops in mem_cgroup_shrink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4899CFA1.60807@linux.vnet.ibm.com>
Date:	Wed, 06 Aug 2008 21:51:53 +0530
From:	Balbir Singh <balbir@...ux.vnet.ibm.com>
To:	Hugh Dickins <hugh@...itas.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] memcg: fix oops in mem_cgroup_shrink_usage

Hugh Dickins wrote:
> Got an oops in mem_cgroup_shrink_usage() when testing loop over tmpfs:
> yes, of course, loop0 has no mm: other entry points check but this didn't.
> 
> Signed-off-by: Hugh Dickins <hugh@...itas.com>
> ---
> 
>  mm/memcontrol.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- 2.6.27-rc2/mm/memcontrol.c	2008-08-06 08:36:20.000000000 +0100
> +++ linux/mm/memcontrol.c	2008-08-06 09:05:26.000000000 +0100
> @@ -796,6 +796,8 @@ int mem_cgroup_shrink_usage(struct mm_st
> 
>  	if (mem_cgroup_subsys.disabled)
>  		return 0;
> +	if (!mm)
> +		return 0;
> 
>  	rcu_read_lock();
>  	mem = mem_cgroup_from_task(rcu_dereference(mm->owner));

Looks good

Acked-by: Balbir Singh <balbir@...ux.vnet.ibm.com>



-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/